Update minimal account implementation address #7397
Conversation
Changed MINIMAL_ACCOUNT_IMPLEMENTATION_ADDRESS to a new address in minimal-account.ts with full granular session key functionality
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe constant representing the minimal account implementation contract address in the EIP-7702 module was updated to a new address. No other code, logic, or exported entity was modified in this change. Changes
Sequence Diagram(s)No sequence diagram generated as the change only updates a constant value and does not affect control flow or interactions. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/src/wallets/in-app/core/eip7702/minimal-account.ts (1)
26-27: Normalize the constant withgetAddressfor consistency.To enforce a checksummed address and avoid manual lowercase comparisons, consider initializing the constant using:
import { getAddress } from "../../../../utils/address.js"; const MINIMAL_ACCOUNT_IMPLEMENTATION_ADDRESS = getAddress( "0x173217d7f8c26Dc3c01e37e1c04813CC7cC9fEc2", );Then you can remove the
.toLowerCase()call inis7702MinimalAccount.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/thirdweb/src/wallets/in-app/core/eip7702/minimal-account.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/thirdweb/src/wallets/in-app/core/eip7702/minimal-account.ts (1)
26-27: Confirm the new minimal account implementation address.Please verify that
0x173217d7f8c26Dc3c01e37e1c04813CC7cC9fEc2is the correct, deployed contract address on all supported chains and that it indeed enables full granular session key functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7397 +/- ##
==========================================
- Coverage 52.20% 52.19% -0.01%
==========================================
Files 945 945
Lines 63578 63578
Branches 4230 4227 -3
==========================================
- Hits 33192 33186 -6
- Misses 30279 30285 +6
Partials 107 107
🚀 New features to boost your workflow:
|
size-limit report 📦
|
0xFirekeeper
added
the
DO NOT MERGE
Changed MINIMAL_ACCOUNT_IMPLEMENTATION_ADDRESS to a new address in minimal-account.ts with full granular session key functionality
PR-Codex overview
This PR updates the implementation address for the minimal account in the
minimal-account.tsfile, which is part of the in-app wallet functionality. This change likely reflects an update in the smart contract address being used.Detailed summary
MINIMAL_ACCOUNT_IMPLEMENTATION_ADDRESSfrom"0xbaC7e770af15d130Cd72838ff386f14FBF3e9a3D"to"0x173217d7f8c26Dc3c01e37e1c04813CC7cC9fEc2"inminimal-account.ts.Summary by CodeRabbit